ARROW-3598: [Plasma] Fix Plasma GPU linking error.#2820
Closed
robertnishihara wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-3598: [Plasma] Fix Plasma GPU linking error.#2820robertnishihara wants to merge 2 commits intoapache:masterfrom
robertnishihara wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2820 +/- ##
=========================================
+ Coverage 87.72% 88.6% +0.87%
=========================================
Files 407 345 -62
Lines 62896 58886 -4010
=========================================
- Hits 55178 52178 -3000
+ Misses 7646 6708 -938
+ Partials 72 0 -72Continue to review full report at Codecov.
|
Member
|
I think this can be resolved by changing the linking order. Either @pitrou or I can take a closer look since we have NVIDIA GPUs available |
Contributor
Author
Change-Id: I1d8584a472089f2de9b30dd38a5cb914b83e76a1
Member
|
That should fix it |
Member
|
I confirm this PR fixes the issue here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should revert to the prior behavior from before all of the linking changes. However, I haven't confirmed that it works. @pitrou could you try this out?