Skip to content

ARROW-3598: [Plasma] Fix Plasma GPU linking error.#2820

Closed
robertnishihara wants to merge 2 commits intoapache:masterfrom
robertnishihara:fixgpulinking
Closed

ARROW-3598: [Plasma] Fix Plasma GPU linking error.#2820
robertnishihara wants to merge 2 commits intoapache:masterfrom
robertnishihara:fixgpulinking

Conversation

@robertnishihara
Copy link
Copy Markdown
Contributor

This should revert to the prior behavior from before all of the linking changes. However, I haven't confirmed that it works. @pitrou could you try this out?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2820 into master will increase coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2820      +/-   ##
=========================================
+ Coverage   87.72%   88.6%   +0.87%     
=========================================
  Files         407     345      -62     
  Lines       62896   58886    -4010     
=========================================
- Hits        55178   52178    -3000     
+ Misses       7646    6708     -938     
+ Partials       72       0      -72
Impacted Files Coverage Δ
cpp/src/arrow/csv/column-builder.cc 94.92% <0%> (-2.18%) ⬇️
rust/src/record_batch.rs
go/arrow/array/table.go
rust/src/util/bit_util.rs
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/null.go
go/arrow/datatype_nested.go
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0176b8f...9fdc93c. Read the comment docs.

@wesm
Copy link
Copy Markdown
Member

wesm commented Oct 23, 2018

I think this can be resolved by changing the linking order. Either @pitrou or I can take a closer look since we have NVIDIA GPUs available

@robertnishihara
Copy link
Copy Markdown
Contributor Author

Thanks @wesm and @pitrou! Let me know what you find. If that ends up working, feel free to directly modify this PR or replace it.

Change-Id: I1d8584a472089f2de9b30dd38a5cb914b83e76a1
@wesm
Copy link
Copy Markdown
Member

wesm commented Oct 23, 2018

That should fix it

@pitrou
Copy link
Copy Markdown
Member

pitrou commented Oct 24, 2018

I confirm this PR fixes the issue here.

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants