ARROW-3656: [C++] Allow whitespace in numeric CSV fields#2875
Closed
pitrou wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-3656: [C++] Allow whitespace in numeric CSV fields#2875pitrou wants to merge 2 commits intoapache:masterfrom
pitrou wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2875 +/- ##
==========================================
+ Coverage 87.55% 88.46% +0.91%
==========================================
Files 411 348 -63
Lines 63818 59605 -4213
==========================================
- Hits 55874 52728 -3146
+ Misses 7870 6877 -993
+ Partials 74 0 -74
Continue to review full report at Codecov.
|
alendit
reviewed
Oct 31, 2018
cpp/src/arrow/csv/converter.cc
Outdated
There was a problem hiding this comment.
Maybe c > ' ' or even c > ' ' && c > '\t' here to make it more explicit? The last one should get optimized to a single comparison anyway.
alendit
reviewed
Oct 31, 2018
cpp/src/arrow/csv/converter.cc
Outdated
There was a problem hiding this comment.
Even though it's not a part of the changeset: why do we use the safe method here, but an unsafe one at around 312? Couldn't it both be unsafe?
Member
Author
|
@wesm Any concern here? Otherwise I'll rebase and merge soon. |
pitrou
force-pushed
the
ARROW-3656-csv-number-whitespace
branch
from
fa4f6e3 to
547b936
Compare
Member
Author
|
+1, will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.