ARROW-3613: [Go] fix builder resize#2927
Closed
alexandreyc wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
Oops, still an issue... Working on it. |
Contributor
Author
|
Should be OK now. |
Contributor
Author
|
The Ruby build seems to be broken. |
Member
|
Probably a transient thing; I just restarted that build. As long as the Go build passes, once someone reviews the patch and it's approved, it can be merged |
wesm
approved these changes
Nov 9, 2018
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1; I was able to read this well enough to see that this behavior is consistent with the docstring. I looked at the C++ implementation and I think that resizing to an absolute size less than the current number of elements in the builder will leave the builders in a bad state. I opened https://issues.apache.org/jira/browse/ARROW-3740 to investigate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Following the discussion on JIRA here is a patch that fixes the issue with resizing builders.
I think that I would be good that someone who knows the codebase better than I do review this PR.
Alexandre