Skip to content

Conversation

@pravindra
Copy link
Contributor

  • added a bitmap fn that returns true if there is no bitmap
  • added more tests

- added a bitmap fn that returns true if there is no bitmap
- added more tests
@codecov-io
Copy link

Codecov Report

Merging #2980 into master will increase coverage by 1.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2980      +/-   ##
==========================================
+ Coverage   86.64%   87.67%   +1.02%     
==========================================
  Files         491      423      -68     
  Lines       69393    63974    -5419     
==========================================
- Hits        60124    56087    -4037     
+ Misses       9177     7887    -1290     
+ Partials       92        0      -92
Impacted Files Coverage Δ
cpp/src/gandiva/llvm_generator.h 100% <ø> (ø) ⬆️
cpp/src/gandiva/annotator.cc 97.95% <ø> (ø) ⬆️
cpp/src/gandiva/llvm_generator.cc 76.41% <100%> (+0.16%) ⬆️
cpp/src/plasma/thirdparty/ae/ae.c 72.03% <0%> (-0.95%) ⬇️
rust/src/record_batch.rs
go/arrow/array/table.go
rust/src/array.rs
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/array/bufferbuilder.go
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83454c...2138f73. Read the comment docs.

Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this :)

@pcmoritz pcmoritz changed the title ARROW-3805: handle null validity bit-map in if-else ARROW-3805: [Gandiva] Handle null validity bit-map in if-else Nov 17, 2018
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants