ARROW-3912: [Plasma][GLib] Add support for creating and referring objects #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiro615
reviewed
Dec 2, 2018
|
|
||
| typedef struct GPlasmaClientPrivate_ { | ||
| std::shared_ptr<plasma::PlasmaClient> client; | ||
| plasma::PlasmaClient *client; |
Contributor
There was a problem hiding this comment.
Is that because this change prevent a memory leak?
Member
Author
There was a problem hiding this comment.
No.
shared_ptr is just not needed here. We don't need to share a plasma::PlasmaClient created by plasma_client_new().
c_glib/plasma-glib/client.cpp
Outdated
| auto plasma_data = plasma_object_buffer.data; | ||
| auto plasma_metadata = plasma_object_buffer.metadata; | ||
| GArrowBuffer *data; | ||
| GArrowBuffer *metadata; |
Contributor
There was a problem hiding this comment.
Do we need to silence the warning?
https://travis-ci.org/apache/arrow/jobs/461631864#L3955
Member
Author
There was a problem hiding this comment.
Yes.
I forgot return NULL after g_set_error().
c_glib/plasma-glib/object.cpp
Outdated
| auto status = plasma_client->Seal(id_priv->id); | ||
| auto success = garrow_error_check(error, status, context); | ||
| if (success) { | ||
| plasma_client->Release(id_priv->id); |
Contributor
There was a problem hiding this comment.
Do we need to receive status to silence the warning?
https://travis-ci.org/apache/arrow/jobs/461631864#L3940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.