ARROW-3209: [C++] Rename libarrow_gpu to libarrow_cuda#3088
ARROW-3209: [C++] Rename libarrow_gpu to libarrow_cuda#3088pitrou wants to merge 7 commits intoapache:masterfrom
Conversation
|
I think the C glib side needs to be fixed, but I'm not sure how. @kou would you like to push something to this PR? |
Also rename the arrow::gpu namespace to arrow::cuda.
7e6e1aa to
9687346
Compare
|
Ah, I forgot about the disruption that this would cause to the glib side, where there are also Linux packages. I think it's a good idea to leave open the possibility of GPU computing outside of CUDA |
|
I'll add some commits for C GLib, Ruby and Linux packages to this PR. |
|
It seems that |
Codecov Report
@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
+ Coverage 87.12% 88.15% +1.03%
==========================================
Files 492 434 -58
Lines 69104 65339 -3765
==========================================
- Hits 60204 57601 -2603
+ Misses 8801 7738 -1063
+ Partials 99 0 -99
Continue to review full report at Codecov.
|
I'd keep it. |
kou
left a comment
There was a problem hiding this comment.
OK.
+1 from me.
We can merge this when Linux packages are built on Travis CI:
https://github.com/kou/crossbow/branches/all?utf8=%E2%9C%93&query=build-53
|
Some of the Linux packages failed |
|
Linux package builds are fixed: https://github.com/kou/crossbow/branches/all?utf8=%E2%9C%93&query=build-54 I'll merge this when CI is passed. |
|
Great, thanks @kou! |
|
CI is green. I'll merge this. |
Also rename the arrow::gpu namespace to arrow::cuda.