Skip to content

ARROW-4008: [C++] Restore ARROW_BUILD_UTILITIES to fix integration tests#3166

Closed
wesm wants to merge 5 commits intoapache:masterfrom
wesm:ARROW-4008
Closed

ARROW-4008: [C++] Restore ARROW_BUILD_UTILITIES to fix integration tests#3166
wesm wants to merge 5 commits intoapache:masterfrom
wesm:ARROW-4008

Conversation

@wesm
Copy link
Copy Markdown
Member

@wesm wesm commented Dec 12, 2018 •
edited
Loading

In recent refactoring, ARROW_BUILD_UTILITIES got accidentally set to OFF

wesm added 3 commits December 12, 2018 14:53
@wesm
Add option to write integration test files to somewhere outside of /t…
af6a23b 
…mp. Add integration target to C++ build

Change-Id: Ie3571cd98f10190bd1a685cd5a682494f0f5d24b
@wesm
Do not write integration test files to /tmp
8c9fcf8 
Change-Id: I440639b5432ab79adefb7b16c71fa693b79d2ce0
@wesm
Add integration target as dependency of arrow target
02fd08f 
Change-Id: If884274e81107e24fbb75c9a90eed42e7ce1d705
@wesm
Copy link
Copy Markdown
Member Author

wesm commented Dec 12, 2018

Doh, the problem is simpler than that:

sh: 1: /home/travis/build/apache/arrow/cpp-build/debug/arrow-file-to-stream: not found
cat /home/travis/build/apache/arrow/integration_temp/0183f25f_struct_example.producer_file_as_stream | /home/travis/build/apache/arrow/cpp-build/debug/arrow-stream-to-file > /home/travis/build/apache/arrow/integration_temp/0183f25f_struct_example.consumer_stream_as_file
sh: 1: /home/travis/build/apache/arrow/cpp-build/debug/arrow-stream-to-file: not found

The utilities aren't being built...

@wesm wesm changed the title ARROW-4008: [C++] Work around /tmp instability in Travis CI when running integration tests ARROW-4008: [C++] Restore ARROW_BUILD_UTILITIES to fix integration tests Dec 12, 2018
wesm added 2 commits December 12, 2018 15:21
@wesm
Actually build utilities
96bec05 
Change-Id: I73be7e5d5b091ef20b95057747b8923bd57fe402
@wesm
Only add json-integration-test dependency when it is built
1056517 
Change-Id: I99de372e94402b9db12b66db6373e3578c91371e
@wesm
Copy link
Copy Markdown
Member Author

wesm commented Dec 12, 2018

+1. Merging this so we get more passing CI builds

@wesm wesm closed this in 4594041 Dec 12, 2018
@wesm wesm deleted the ARROW-4008 branch December 12, 2018 22:11
@asfimport asfimport mentioned this pull request Mar 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesm