ARROW-4073: [Python] Fix URI parsing on Windows. Also fix test for get_library_dirs when using ARROW_HOME to develop#3218
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-4073: [Python] Fix URI parsing on Windows. Also fix test for get_library_dirs when using ARROW_HOME to develop#3218wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
…les are installed in ARROW_HOME and not the usual conda/pip locations
pitrou
reviewed
Dec 18, 2018
| return parsed_uri.path | ||
| else: | ||
| # ARROW-4073: On Windows returning the path with the scheme | ||
| # stripped removes the drive letter, if any |
pitrou
approved these changes
Dec 18, 2018
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1 (but there's a linting error)
Codecov Report
@@ Coverage Diff @@
## master #3218 +/- ##
==========================================
+ Coverage 86.43% 87.56% +1.13%
==========================================
Files 508 450 -58
Lines 70058 66050 -4008
==========================================
- Hits 60557 57839 -2718
+ Misses 9398 8211 -1187
+ Partials 103 0 -103
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ARROW-4074