Skip to content

ARROW-4089: [Plasma] The tutorial is wrong regarding the parameter type of PlasmaClient.Create#3235

Closed
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:fix-plasma-tutorial
Closed

ARROW-4089: [Plasma] The tutorial is wrong regarding the parameter type of PlasmaClient.Create#3235
sarutak wants to merge 1 commit intoapache:masterfrom
sarutak:fix-plasma-tutorial

Conversation

@sarutak
Copy link
Copy Markdown
Member

@sarutak sarutak commented Dec 20, 2018

Plasma's tutorial says that the data type of one parameter is address of uint8_t* but it's actually address of shared_ptr<Buffer>.

uint8_t* data;                <------------------------------- wrong data type here.
 // Create a Plasma object by specifying its ID and size.
 ARROW_CHECK_OK(client.Create(object_id, data_size, NULL, 0, &data));

@@ -182,7 +182,7 @@ was written by the `Create` command.
int64_t data_size = 100;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should perhaps turn this into an example we compile and include it in the Sphinx documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants