ARROW-3932: [Python] Include Benchmarks.md in Sphinx docs#3249
Closed
xhochy wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-3932: [Python] Include Benchmarks.md in Sphinx docs#3249xhochy wants to merge 2 commits intoapache:masterfrom
xhochy wants to merge 2 commits intoapache:masterfrom
Conversation
pitrou
reviewed
Dec 22, 2018
| api | ||
| development | ||
| getting_involved | ||
| benchmarks |
Member
There was a problem hiding this comment.
Perhaps we may want to group "development", "getting involved" and "benchmarks" in a subchapter.
Member
Author
There was a problem hiding this comment.
Is there a simple way to do this in a toctree or should we start a subfolder contributing?
pitrou
reviewed
Dec 22, 2018
| under the License. | ||
| --> | ||
|
|
||
| # Benchmarks |
Member
There was a problem hiding this comment.
Perhaps keep the README file but just put a redirect to the Sphinx docs?
(which, unfortunately, aren't online yet...) @wesm
Member
Author
There was a problem hiding this comment.
Manually pushed them: http://arrow.apache.org/docs/latest/
They are not linked from anywhere yet though.
Member
Author
|
+1, merging. I can address additional comments in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.