ARROW-543: C++: Lazily computed null_counts counts number of non-null entries #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
commented
Feb 8, 2017
| null_count_(null_count), | ||
| null_bitmap_(null_bitmap), | ||
| null_bitmap_data_(nullptr) { | ||
| if (null_count_ == 0) { null_bitmap_ = nullptr; } |
Member
Author
There was a problem hiding this comment.
Actually first thought this might be the issue (i.e. using a non-valid bitmap) but it wasn't. Still for null_count == 0 we don't need it and leaving out the reference even makes the lazy branch of null_count() a lot faster.
wesm
approved these changes
Feb 8, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1, will wait for the build to pass
| if (null_count_ < 0) { | ||
| if (null_bitmap_) { | ||
| null_count_ = CountSetBits(null_bitmap_data_, offset_, length_); | ||
| null_count_ = length_ - CountSetBits(null_bitmap_data_, offset_, length_); |
Member
|
Green build here: https://travis-ci.org/xhochy/arrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.