Skip to content

ARROW-4183: [Ruby] Add Arrow::Struct as an element of Arrow::StructArray#3338

Closed
kou wants to merge 1 commit intoapache:masterfrom
kou:ruby-struct
Closed

ARROW-4183: [Ruby] Add Arrow::Struct as an element of Arrow::StructArray#3338
kou wants to merge 1 commit intoapache:masterfrom
kou:ruby-struct

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Jan 7, 2019

Returning Arrow::Array by Arrow::StructArray#[] is deprecated. It'll
return Arrow::Struct in the next release. It's for consistency. All
Arrow::Array#[] implementations should return an element.

Returning Arrow::Array by Arrow::StructArray#[] is deprecated.  It'll
return Arrow::Struct in the next release. It's for consistency. All
Arrow::Array#[] implementations should return an element.
Copy link
Copy Markdown
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants