Skip to content

ARROW-4207: [Gandiva] [GLib] Add support for IfNode#3354

Closed
shiro615 wants to merge 2 commits intoapache:masterfrom
shiro615:glib-add-support-for-if-node
Closed

ARROW-4207: [Gandiva] [GLib] Add support for IfNode#3354
shiro615 wants to merge 2 commits intoapache:masterfrom
shiro615:glib-add-support-for-if-node

Conversation

@shiro615
Copy link
Copy Markdown
Contributor

@shiro615 shiro615 commented Jan 9, 2019

No description provided.

@shiro615 shiro615 changed the title ARROW-4207: [GLib] Add support for IfNode ARROW-4207: [Gandiva] [GLib] Add support for IfNode Jan 9, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3354 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
+ Coverage   88.36%   88.37%   +<.01%     
==========================================
  Files         557      557              
  Lines       73560    73562       +2     
==========================================
+ Hits        65001    65008       +7     
+ Misses       8450     8449       -1     
+ Partials      109      105       -4
Impacted Files Coverage Δ
go/arrow/math/uint64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/float64_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/memory/memory_sse4_amd64.go 0% <0%> (-100%) ⬇️
go/arrow/math/int64_sse4_amd64.go 0% <0%> (-100%) ⬇️
cpp/src/plasma/store.cc 91.32% <0%> (-0.78%) ⬇️
cpp/src/arrow/vendored/xxhash/xxhash.c 73.6% <0%> (-0.51%) ⬇️
go/arrow/math/float64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/int64_amd64.go 33.33% <0%> (ø) ⬆️
go/arrow/math/uint64_amd64.go 33.33% <0%> (ø) ⬆️
cpp/src/arrow/util/bpacking.h 99.84% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090a8c0...8058b2c. Read the comment docs.

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you check my comment?

@kou
Copy link
Copy Markdown
Member

kou commented Jan 10, 2019

Rust build failure is unrelated. I'll merge this.

@kou kou closed this in ea69e8f Jan 10, 2019
@shiro615 shiro615 deleted the glib-add-support-for-if-node branch January 10, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants