Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jan 9, 2019

It will be harder to add generated API docs without requiring CUDA support on the machine building the docs.

It will be harder to add generated API docs without requiring CUDA support
on the machine building the docs.
@wesm
Copy link
Member

wesm commented Jan 9, 2019

Does Sphinx support any kind of feature flags at the rst level? (for the autosummary generated things)

@pitrou
Copy link
Member Author

pitrou commented Jan 9, 2019

Not sure what you mean... something like conditional generation?

@pitrou
Copy link
Member Author

pitrou commented Jan 9, 2019

Apparently there's the "ifconfig" extension.

@wesm
Copy link
Member

wesm commented Jan 9, 2019

Right, what I'm saying is to add some kind of a marker to a section to be ignored if some condition in the configuration file is set (i.e. based on whether a certain module is available or not).

So if there were a section with CUDA functions then they would not appear in the generated version of

https://raw.githubusercontent.com/apache/arrow/master/docs/source/python/api.rst

@pitrou
Copy link
Member Author

pitrou commented Jan 9, 2019

I see. I could tackle that in this PR or in another PR/JIRA, as you prefer.

(then we need to upload official docs from a CUDA-enabled machine - or perhaps only the CUDA toolkit is needed? I'm not sure)

@wesm
Copy link
Member

wesm commented Jan 9, 2019

I'm not sure either. Now that UL has some physical CUDA-enabled hardware I would be fine with giving committers non-sudo accounts with the ability to use nvidia-docker to build the docs in a CUDA-equipped environment, so that is one way around this at least

@wesm
Copy link
Member

wesm commented Jan 9, 2019

Either here or another PR is fine with me. Having these initial docs for the 0.12 release would be useful even if the Python packages won't have CUDA support yet

@pitrou
Copy link
Member Author

pitrou commented Jan 9, 2019

I'm thinking mainly about automated builds. I have CUDA installed locally myself ;-)

@pitrou
Copy link
Member Author

pitrou commented Jan 9, 2019

Ok, I'm gonna merge this PR and open a JIRA for the API docs, then.

@wesm
Copy link
Member

wesm commented Jan 9, 2019

Ah, I see. As soon as we have a Jenkins-like automation tool configured we can run nightly docs builds on these machines

@pitrou pitrou closed this in bcfacaa Jan 9, 2019
@pitrou pitrou deleted the ARROW-3233-pyarrow-cuda-doc branch January 9, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants