Skip to content

GH-15139: [C++] Improve bzip2 static library path detection for arrow.pc #33712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Jan 18, 2023
Merged

GH-15139: [C++] Improve bzip2 static library path detection for arrow.pc #33712

kou merged 1 commit into from
Jan 18, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Jan 17, 2023 •
edited by github-actions bot
Loading

Rationale for this change

If bzip2 is installed for debug build and release build on Windows, find_package(BZip2)
returns both static library paths of them.

What changes are included in this PR?

We should use one of detected library paths in arrow.pc.

The bzip2's official build system doesn't provide bzip2.pc but vcpkg provides bzip2.pc. We can use it instead of detecting bzip2's static library path by ourselves.

Are these changes tested?

Yes. We test these changes in #15139 manually.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Jan 17, 2023

@kou kou mentioned this pull request Jan 17, 2023
Closed
@kou
apacheGH-15139: [C++] Improve bzip2 static library path detection for…
7b895aa 
… arrow.pc

If bzip2 is installed for debug build and release build on Windows,
find_package(BZip2) returns both static library paths of them. We
should use one of them in arrow.pc.

The bzip2's official build system doesn't provide bzip2.pc but vcpkg
provides bzip2.pc. We can use it instead of detecting bzip2's static
library path by ourselves.
@kou
Copy link
Member Author

kou commented Jan 18, 2023

+1

@kou kou merged commit 359f28b into apache:master Jan 18, 2023
@kou kou deleted the cpp-pc-bzip2 branch January 18, 2023 14:21
@ursabot
Copy link

ursabot commented Jan 20, 2023

Benchmark runs are scheduled for baseline = e837f73 and contender = 359f28b. 359f28b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.19% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 359f28ba ec2-t3-xlarge-us-east-2
[Failed] 359f28ba test-mac-arm
[Finished] 359f28ba ursa-i9-9960x
[Finished] 359f28ba ursa-thinkcentre-m75q
[Finished] e837f73b ec2-t3-xlarge-us-east-2
[Finished] e837f73b test-mac-arm
[Finished] e837f73b ursa-i9-9960x
[Finished] e837f73b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@lukester1975 lukester1975 mentioned this pull request Jan 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] arrow.pc is missing dependencies with Windows static builds

2 participants

@kou @ursabot