Skip to content

Conversation

@zeroshade
Copy link
Member

@zeroshade zeroshade commented Jan 26, 2023

Rationale for this change

Fixing a memory leak of malloc'd uintptr_t values used for cgo handles

What changes are included in this PR?

calling free on the handles after deleting the Go objects they point at, add static keyword to the helper function definitions in helpers.h so that compiling without optimizations for debugging doesn't fail.

@zeroshade zeroshade requested a review from lidavidm January 26, 2023 17:52
@github-actions
Copy link

@zeroshade zeroshade merged commit 8f537ca into apache:master Jan 26, 2023
@zeroshade zeroshade deleted the cdata-leak-debug-fix branch January 26, 2023 18:06
@ursabot
Copy link

ursabot commented Jan 27, 2023

Benchmark runs are scheduled for baseline = af400a8 and contender = 8f537ca. 8f537ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.22% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.47% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8f537ca9 ec2-t3-xlarge-us-east-2
[Failed] 8f537ca9 test-mac-arm
[Failed] 8f537ca9 ursa-i9-9960x
[Finished] 8f537ca9 ursa-thinkcentre-m75q
[Finished] af400a81 ec2-t3-xlarge-us-east-2
[Failed] af400a81 test-mac-arm
[Failed] af400a81 ursa-i9-9960x
[Finished] af400a81 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go] cdata package leaks handles, difficulty debugging

3 participants