ARROW-4287: [C++] Ensure minimal bison version on OSX for Thrift#3427
Closed
xhochy wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-4287: [C++] Ensure minimal bison version on OSX for Thrift#3427xhochy wants to merge 2 commits intoapache:masterfrom
xhochy wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3427 +/- ##
==========================================
+ Coverage 88.32% 89.29% +0.97%
==========================================
Files 631 502 -129
Lines 79308 70343 -8965
Branches 1069 0 -1069
==========================================
- Hits 70048 62814 -7234
+ Misses 9145 7529 -1616
+ Partials 115 0 -115Continue to review full report at Codecov.
|
kou
reviewed
Jan 18, 2019
Member
There was a problem hiding this comment.
Can we use ${BISON_EXECUTABLE} here?
Member
There was a problem hiding this comment.
We can simplify this:
if (BREW_BIN)
wesm
force-pushed
the
ARROW-4287
branch
2 times, most recently
from
84eebc4 to
c012cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.