Conversation
cpp/CMakeLists.txt
Outdated
There was a problem hiding this comment.
I would prefer if we could read them from some generated location. In Python we use at the moment git describe and as a fallback the Java pom.xml to determine the version number as those two get automatically updated on a release.
There was a problem hiding this comment.
As an alternative, we could add a .arrowversion file to the root of the repository that is updated with the release scripts. We do this in the release scripts of parquet-cpp. The main problem in Arrow is that we use the Maven release plugin and we haven't yet found a hook to write out the version string in the correct commit in a non-xml file.
There was a problem hiding this comment.
I've changed the code to get version from java/pom.xml.
*.pc.in such as cpp/build/arrow.pc.in refers ARROW_VERSION but it isn't defined.
kou
force-pushed
the
arrow-569-c++-set-version-for-pc
branch
from
f44cff1 to
48b366b
Compare
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#344 from wesm/PARQUET-967 and squashes the following commits: e059c6e [Wes McKinney] Remove PARQUET_ARROW CMake flag eb24ce7 [Wes McKinney] Combine libparquet, libparquet_arrow Change-Id: I4951c91bbe2616e99c023ee18de7b0ba2662b2c2
2 participants
*.pc.in such as cpp/build/arrow.pc.in refers ARROW_VERSION but it isn't
defined.