Skip to content

Conversation

@yevgenypats
Copy link
Contributor

@yevgenypats yevgenypats commented Apr 3, 2023

@yevgenypats yevgenypats requested a review from zeroshade as a code owner April 3, 2023 10:43
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@zeroshade
Copy link
Member

@yevgenypats For future reference: the style for naming the PRs is GH-####: [Go] ... don't put brackets around the GH-##### part and the CI will automatically pick it up and add the "closes" comment for you. I've updated the title for this PR but just mentioning it for your future PRs. Thanks! I'll take a look at this in just a bit. I'm just catching up on notifications from while i was at a conference last week 😄

@zeroshade zeroshade changed the title [GH-34853][Go]: Add TotalRecordSize, TotalArraySize GH-34853: [Go] Add TotalRecordSize, TotalArraySize Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

⚠️ GitHub issue #34853 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 7, 2023
@yevgenypats yevgenypats requested a review from zeroshade April 7, 2023 14:40
@yevgenypats
Copy link
Contributor Author

Thanks @zeroshade and sorry for the delay here. Addressed the review.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 10, 2023
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some very nitpicky things for formatting, but otherwise LGTM

@yevgenypats yevgenypats requested a review from zeroshade April 10, 2023 15:00
@github-actions github-actions bot removed the awaiting changes Awaiting changes label Apr 10, 2023
@github-actions github-actions bot added the awaiting change review Awaiting change review label Apr 10, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 10, 2023
@yevgenypats yevgenypats requested a review from zeroshade April 10, 2023 16:02
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 10, 2023
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 10, 2023
@yevgenypats yevgenypats requested a review from zeroshade April 10, 2023 18:24
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 10, 2023
@zeroshade zeroshade merged commit 2fe1733 into apache:main Apr 10, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Apr 10, 2023
@ursabot
Copy link

ursabot commented Apr 11, 2023

Benchmark runs are scheduled for baseline = 76e8cb5 and contender = 2fe1733. 2fe1733 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.24% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.15% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 2fe17338 ec2-t3-xlarge-us-east-2
[Finished] 2fe17338 test-mac-arm
[Finished] 2fe17338 ursa-i9-9960x
[Finished] 2fe17338 ursa-thinkcentre-m75q
[Finished] 76e8cb5f ec2-t3-xlarge-us-east-2
[Finished] 76e8cb5f test-mac-arm
[Finished] 76e8cb5f ursa-i9-9960x
[Finished] 76e8cb5f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
Closes apache#34853
* Closes: apache#34853

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
Closes apache#34853
* Closes: apache#34853

Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@candiduslynx candiduslynx deleted the feat/total_array_size branch June 2, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Go][Util] TotalBufferSize

3 participants