-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-34853: [Go] Add TotalRecordSize, TotalArraySize #34854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
|
@yevgenypats For future reference: the style for naming the PRs is |
|
|
|
Thanks @zeroshade and sorry for the delay here. Addressed the review. |
zeroshade
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some very nitpicky things for formatting, but otherwise LGTM
|
Benchmark runs are scheduled for baseline = 76e8cb5 and contender = 2fe1733. 2fe1733 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Closes apache#34853 * Closes: apache#34853 Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Closes apache#34853 * Closes: apache#34853 Authored-by: Yevgeny Pats <16490766+yevgenypats@users.noreply.github.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Closes #34853