ARROW-588: [C++] Fix some 32 bit compiler warnings#354
Closed
wesm wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-588: [C++] Fix some 32 bit compiler warnings#354wesm wants to merge 5 commits intoapache:masterfrom
wesm wants to merge 5 commits intoapache:masterfrom
Conversation
Change-Id: Iae9f55a6b0f514f56040fe29c7e33836af189ed5
Change-Id: I05161e46fc1191a4158d6cd56f43b781649ffe52
Change-Id: I9e300438563ce0b0ebd55fa454d0c453f74eccde
Change-Id: I6afb888cf266f4433ed95fbaa2f7114c4ad0b67b
Member
Author
|
I found a small buglet |
Member
Author
|
green build: https://travis-ci.org/wesm/arrow/builds/205857033 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Author: Uwe L. Korn <uwe@apache.org> Closes apache#354 from xhochy/PARQUET-1033 and squashes the following commits: 895676a [Uwe L. Korn] Remove trailing comment line 709ef32 [Uwe L. Korn] PARQUET-1033: Improve documentation about WriteBatchSpaced Change-Id: Id3c813519b6ef1fd77c290cd163fc599a5ffcaf1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also found that $CMAKE_CXX_FLAGS were not being passed to the gflags external project.