Skip to content

ARROW-4355: [C++] Reorder testing code into src/arrow/testing#3591

Closed
xhochy wants to merge 3 commits intoapache:masterfrom
xhochy:ARROW-4355
Closed

ARROW-4355: [C++] Reorder testing code into src/arrow/testing#3591
xhochy wants to merge 3 commits intoapache:masterfrom
xhochy:ARROW-4355

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Feb 8, 2019

Prefixed files that depend on gtest with gtest_ to make it visible to the user that they are not part of Arrow C++ core.

@fsaintjacques
Copy link
Contributor

My approval is dependent on making it compile and pass test of course :)

@wesm
Copy link
Member

wesm commented Feb 10, 2019

Rebasing this. Will try to merge this soon since otherwise it'll keep conflicting

@wesm wesm closed this in 7f13b70 Feb 11, 2019
@wesm wesm deleted the ARROW-4355 branch February 11, 2019 03:49
@wesm
Copy link
Member

wesm commented Feb 11, 2019

Some C++ branches may need to be rebased as a result of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants