Skip to content

ARROW-4434: [Python] Allow creating trivial StructArray#3610

Closed
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-4434-empty-struct-array
Closed

ARROW-4434: [Python] Allow creating trivial StructArray#3610
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-4434-empty-struct-array

Conversation

@pitrou
Copy link
Copy Markdown
Member

@pitrou pitrou commented Feb 11, 2019

Also fix an unrelated flake8 error with the latest flake8.

Also fix an unrelated flake8 error with the latest flake8.
@pitrou pitrou force-pushed the ARROW-4434-empty-struct-array branch from beff3b9 to 1190f53 Compare February 11, 2019 17:17
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #3610 into master will decrease coverage by 21.19%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
- Coverage   87.75%   66.56%   -21.2%     
==========================================
  Files         673      322     -351     
  Lines       82763    47952   -34811     
  Branches     1069        0    -1069     
==========================================
- Hits        72628    31918   -40710     
- Misses      10020    16034    +6014     
+ Partials      115        0     -115
Impacted Files Coverage Δ
python/pyarrow/filesystem.py 51.32% <0%> (ø) ⬆️
python/pyarrow/tests/test_convert_builtin.py 99.52% <100%> (ø) ⬆️
python/pyarrow/array.pxi 69.19% <92.3%> (+0.21%) ⬆️
cpp/src/arrow/pretty_print.h 0% <0%> (-100%) ⬇️
cpp/src/parquet/murmur3.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/memory.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/testing/util.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/compute/kernels/aggregate.cc 0% <0%> (-100%) ⬇️
cpp/src/arrow/io/hdfs-internal.h 0% <0%> (-100%) ⬇️
cpp/src/arrow/util/sse-util.h 0% <0%> (-100%) ⬇️
... and 498 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 133d402...1190f53. Read the comment docs.

Copy link
Copy Markdown
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 6b78fba Feb 11, 2019
@pitrou pitrou deleted the ARROW-4434-empty-struct-array branch February 11, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants