Skip to content

GH-37051: [Dev][JS] Add Dependabot configuration for npm#37053

Merged
kou merged 2 commits into
apache:mainfrom
kou:ci-dependabot-js
Aug 9, 2023
Merged

GH-37051: [Dev][JS] Add Dependabot configuration for npm#37053
kou merged 2 commits into
apache:mainfrom
kou:ci-dependabot-js

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Aug 7, 2023

Rationale for this change

We can add MINOR: [JS] prefix to PRs from Dependabot automatically.

What changes are included in this PR?

Add a configuration for npm.

Are these changes tested?

No. I want to test this by merging this to main.

Are there any user-facing changes?

No.

@kou kou requested review from assignUser and raulcd as code owners August 7, 2023 21:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 7, 2023

⚠️ GitHub issue #37051 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Aug 7, 2023
Copy link
Copy Markdown
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. @domoritz what do you think?

@domoritz
Copy link
Copy Markdown
Member

domoritz commented Aug 8, 2023

I don't think we need weekly updates since it would just add extra work to review and merge.

Do we have a script to automatically merge patch and minor updates that don't break the tests?

@assignUser
Copy link
Copy Markdown
Member

I don't think we need weekly updates since it would just add extra work to review and merge.

We can change the interval to monthly?

Do we have a script to automatically merge patch and minor updates that don't break the tests?

While technically possible I don't think the ASF policy would allow that (only if the bot was using a PAT by a committer who would then be personally responsible for any changes contributed with their PAT.)

@kou
Copy link
Copy Markdown
Member Author

kou commented Aug 8, 2023

If we can merge PRs from Dependabot only when CI is green, I'll do it. It's not a large work.

Do we have a script to automatically merge patch and minor updates that don't break the tests?

We can do it by a on: pull_request_target GitHub Actions workflow. But it's out-of-scope of this. This just wants to prepare title of PRs from Dependabot. Formatting PR titles by hand is a very bother task for me.

@domoritz
Copy link
Copy Markdown
Member

domoritz commented Aug 8, 2023

That all sounds good to me. I'd change it to monthly.

Comment thread .github/dependabot.yml Outdated
@kou
Copy link
Copy Markdown
Member Author

kou commented Aug 9, 2023

OK. I've changed to "monthly".
I'll merge this.

@kou kou merged commit 77d87a9 into apache:main Aug 9, 2023
@kou kou deleted the ci-dependabot-js branch August 9, 2023 00:12
@kou kou removed the awaiting committer review Awaiting committer review label Aug 9, 2023
@github-actions github-actions Bot added the awaiting changes Awaiting changes label Aug 9, 2023
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 77d87a9.

There were 3 benchmark results indicating a performance regression:

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…e#37053)

### Rationale for this change

We can add `MINOR: [JS] ` prefix to PRs from Dependabot automatically.

### What changes are included in this PR?

Add a configuration for npm.

### Are these changes tested?

No. I want to test this by merging this to main.

### Are there any user-facing changes?

No.
* Closes: apache#37051

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting changes Awaiting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dev][JS] Add Dependabot configuration for npm

3 participants