Skip to content

ARROW-4652: [JS] Ensure RBReader transform-stream stays open when autoDestroy=false#3727

Closed
trxcllnt wants to merge 2 commits intoapache:masterfrom
trxcllnt:js/fix-reader-through-stream-autodestroy
Closed

ARROW-4652: [JS] Ensure RBReader transform-stream stays open when autoDestroy=false#3727
trxcllnt wants to merge 2 commits intoapache:masterfrom
trxcllnt:js/fix-reader-through-stream-autodestroy

Conversation

@trxcllnt
Copy link
Contributor

Closes https://issues.apache.org/jira/browse/ARROW-4652. Updates arrow2csv to print all tables from stdin, instead of stopping after the first.

@codecov-io
Copy link

Codecov Report

Merging #3727 into master will increase coverage by 2.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3727      +/-   ##
==========================================
+ Coverage   87.47%   90.36%   +2.88%     
==========================================
  Files         627       74     -553     
  Lines       80413     5325   -75088     
  Branches        0     1200    +1200     
==========================================
- Hits        70344     4812   -65532     
+ Misses       9960      504    -9456     
+ Partials      109        9     -100
Impacted Files Coverage Δ
js/src/ipc/node/reader.ts 100% <100%> (ø)
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
... and 692 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1442fb6...184888a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants