MINOR: [R] Update reference to data.frame which should say tibble instead #37335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: R
awaiting committer review
paleolimbot
approved these changes
Aug 23, 2023
Member
paleolimbot
left a comment
paleolimbot
left a comment
There was a problem hiding this comment.
Probably also need devtools::document()?
github-actions
bot
added
awaiting merge
Member
Author
Doesn't need it, find+replace had accidentally replaced the correct value in the .Rd file, so it's a no-op |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6d3cbda. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…tead (apache#37335) ### Rationale for this change Incorrect information in docs ### What changes are included in this PR? Change ref to `data.frame` to `tibble` instead ### Are these changes tested? No ### Are there any user-facing changes? No Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Incorrect information in docs
What changes are included in this PR?
Change ref to
data.frametotibbleinsteadAre these changes tested?
No
Are there any user-facing changes?
No