MINOR: [Go] Export IndexBuilder struct #37438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow accessing the IndexBuilder since apacheGH-37416 merged. While `Append` can be called on the returned struct, the inner builder cannot be accessed. Besides that returning non-exported types comes with all sorts of odd ergonomics.
Contributor
Author
|
cc @zeroshade |
zeroshade
approved these changes
Aug 29, 2023
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 439d066. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
We allow accessing the IndexBuilder since apacheGH-37416 merged. While the `Builder` interface functions can be accessed, the actual array builder cannot. ### Rationale for this change apache#37416 added the function to access the index builder, but since it returns the `Builder` interface, we can't actually access the underlying builder as the unexported `IndexBuilder` is unexported. Alternatives could be: * Return `indexBuilder.Builder` instead in the `IndexBuilder()` function * Return the unexported `indexBuilder` type, but this tends to be more awkward to use ### What changes are included in this PR? Exporting the type so it can be type asserted. ### Are these changes tested? Yes, rolled this out in our infra. ### Are there any user-facing changes? Yes, but this API hasn't been released yet. Authored-by: Frederic Branczyk <fbranczyk@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
We allow accessing the IndexBuilder since apacheGH-37416 merged. While the `Builder` interface functions can be accessed, the actual array builder cannot. ### Rationale for this change apache#37416 added the function to access the index builder, but since it returns the `Builder` interface, we can't actually access the underlying builder as the unexported `IndexBuilder` is unexported. Alternatives could be: * Return `indexBuilder.Builder` instead in the `IndexBuilder()` function * Return the unexported `indexBuilder` type, but this tends to be more awkward to use ### What changes are included in this PR? Exporting the type so it can be type asserted. ### Are these changes tested? Yes, rolled this out in our infra. ### Are there any user-facing changes? Yes, but this API hasn't been released yet. Authored-by: Frederic Branczyk <fbranczyk@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow accessing the IndexBuilder since GH-37416 merged. While the
Builderinterface functions can be accessed, the actual array builder cannot.Rationale for this change
#37416 added the function to access the index builder, but since it returns the
Builderinterface, we can't actually access the underlying builder as the unexportedIndexBuilderis unexported.Alternatives could be:
indexBuilder.Builderinstead in theIndexBuilder()functionindexBuildertype, but this tends to be more awkward to useWhat changes are included in this PR?
Exporting the type so it can be type asserted.
Are these changes tested?
Yes, rolled this out in our infra.
Are there any user-facing changes?
Yes, but this API hasn't been released yet.