ARROW-4712: [C++][CI] fix build (sum.cc) has warnings in clang#3778
Closed
emkornfield wants to merge 4 commits intoapache:masterfrom
Closed
ARROW-4712: [C++][CI] fix build (sum.cc) has warnings in clang#3778emkornfield wants to merge 4 commits intoapache:masterfrom
emkornfield wants to merge 4 commits intoapache:masterfrom
Conversation
emkornfield
changed the title
Member
|
AppVeyor build: |
Member
|
could these have been caught in CI? |
Contributor
|
It's weird because I build with clang-7, is it a different WARN_LEVEL? |
Member
|
I've found that the warnings can depend on which base gcc toolchain you have |
Member
|
Oh I think the issue is that the Mean patch introduced these issues but that was tested before the clang-7 fix yesterday e648a76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.