ARROW-624: [C++] Restore MakePrimitiveArray function, use in feather.cc#378
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-624: [C++] Restore MakePrimitiveArray function, use in feather.cc#378wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
…quet test suite Change-Id: I18de72604d09cedd3731093160e4a00c6e38c623
Change-Id: Ic281d2f25806e49ea2d6c6ae5e8dc4a618a33507
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Mar 15, 2017
I verified locally the parquet-cpp test suite passes again Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#378 from wesm/ARROW-624 and squashes the following commits: 023df9b [Wes McKinney] Use passed offset in MakePrimitiveArray 30a553e [Wes McKinney] Restore MakePrimitiveArray function, use in Feather, verify fixes parquet test suite
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
The main change made is that you don't have to specify the size of a row-group upfront when writing it. This is signalled through a "row_count_determined" flag which is threaded through the relevant classes. The AppendRowGroup(int64_t num_rows) method should have identical behaviour as before. The AppendRowGroup() method should fix its row group after completing a single column, and enforce all future columns match that. Empty row groups are still not allowed. (You'll definitely want to squash these commits. Apologies for the poor git usage.) Author: Toby Shaw <labuser@LABWKS10> Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#378 from TobyShaw/master and squashes the following commits: 5ba1b75 [Wes McKinney] * Remove number of expected rows from ColumnWriter in a backwards compatible way, refactoring * Fix issue where column length was being checked twice after failed write 14bc5e8 [Toby Shaw] Allow arbitrary size row groups Change-Id: Ieaf0675f3f4939379ca63e60bbf6efe9081abcd2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I verified locally the parquet-cpp test suite passes again