Skip to content

ARROW-4769: [Rust] Improve array limit fn where max_records >= len#3811

Closed
nevi-me wants to merge 1 commit intoapache:masterfrom
nevi-me:ARROW-4769
Closed

ARROW-4769: [Rust] Improve array limit fn where max_records >= len#3811
nevi-me wants to merge 1 commit intoapache:masterfrom
nevi-me:ARROW-4769

Conversation

@nevi-me
Copy link
Copy Markdown
Contributor

@nevi-me nevi-me commented Mar 5, 2019

This yields a ~55% reduction in runtime.

@nevi-me
Copy link
Copy Markdown
Contributor Author

nevi-me commented Mar 5, 2019

@ntrinquier looks like we needed to take ArrayRef to make the copying work

@ntrinquier
Copy link
Copy Markdown

Awesome @nevi-me !

Copy link
Copy Markdown
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants