Skip to content

ARROW-4776: [C++] Add DictionaryBuilder constructor which takes a dictionary array#3867

Closed
bkietz wants to merge 4 commits intoapache:masterfrom
bkietz:ARROW-4776-dictionarybuilder-should-support-bootstrapping-from-an-existing-dict-type
Closed

ARROW-4776: [C++] Add DictionaryBuilder constructor which takes a dictionary array#3867
bkietz wants to merge 4 commits intoapache:masterfrom
bkietz:ARROW-4776-dictionarybuilder-should-support-bootstrapping-from-an-existing-dict-type

Conversation

@bkietz
Copy link
Copy Markdown
Member

@bkietz bkietz commented Mar 11, 2019

DictionaryBuilder can now be constructed with a user provided dictionary.

This is also available through MakeBuilder

bkietz added 2 commits March 11, 2019 16:22
DictionaryBuilder can now be constructed with a given dictionary.
This is now available in MakeBuilder
@bkietz bkietz changed the title ARROW-4776: [C++] Add dictionary constructor to DictionaryBuilder ARROW-4776: [C++] Add DictionaryBuilder constructor which takes a dictionary array Mar 12, 2019
@bkietz
Copy link
Copy Markdown
Member Author

bkietz commented Mar 12, 2019

this PR should also resolve https://issues.apache.org/jira/browse/ARROW-4671

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick otherwise LGTM

@bkietz
Copy link
Copy Markdown
Member Author

bkietz commented Mar 13, 2019

@kszucs postgres hash mismatch in the JDK job, could you restart it?

Copy link
Copy Markdown
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@xhochy xhochy closed this in 65d0e19 Mar 13, 2019
@bkietz bkietz deleted the ARROW-4776-dictionarybuilder-should-support-bootstrapping-from-an-existing-dict-type branch April 8, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants