ARROW-3843: [C++][Python] Allow a "degenerate" Parquet file with no columns#3985
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-3843: [C++][Python] Allow a "degenerate" Parquet file with no columns#3985wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
Member
|
@wesm Tests are failing. |
Member
Author
|
Will fix |
Member
Author
|
This should be good now |
fsaintjacques
requested changes
Mar 22, 2019
| // Degenerate case of Parquet file with no columns | ||
| return GroupNode::FromParquet(static_cast<const void*>(&root), next_id(), {}); | ||
| } else { | ||
| throw ParquetException( |
Contributor
There was a problem hiding this comment.
Didn't know we could throw in parquet.
fsaintjacques
approved these changes
Mar 22, 2019
Contributor
|
OSX failing tests is due to LLVM7 brew error. AppVeyoer is due to anaconda http mirror failure. |
kszucs
pushed a commit
that referenced
this pull request
Mar 24, 2019
…olumns Author: Wes McKinney <wesm+git@apache.org> Closes #3985 from wesm/ARROW-3843 and squashes the following commits: 2aba926 <Wes McKinney> Add C++ unit test for zero-columns. Distinguish from degenerate root node 1588a08 <Wes McKinney> Allow a degenerate Parquet file with no columns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.