Skip to content

ARROW-4977: [Ruby] Add support for building on Windows#3994

Closed
kou wants to merge 2 commits intoapache:masterfrom
kou:ruby-windows
Closed

ARROW-4977: [Ruby] Add support for building on Windows#3994
kou wants to merge 2 commits intoapache:masterfrom
kou:ruby-windows

Conversation

@kou
Copy link
Copy Markdown
Member

@kou kou commented Mar 20, 2019

No description provided.

@kou
Copy link
Copy Markdown
Member Author

kou commented Mar 23, 2019

I've rebased on master and enabled test for Ruby on AppVeyor.
AppVeyor CI is passed. Test for macOS on Travis CI is failed. I think that this isn't related. I restarted the job.

Copy link
Copy Markdown
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI is passed. I'll merge this.

@shiro615 shiro615 closed this Mar 23, 2019
@kou kou deleted the ruby-windows branch March 23, 2019 20:20
kszucs pushed a commit that referenced this pull request Mar 24, 2019
Author: Kouhei Sutou <kou@clear-code.com>

Closes #3994 from kou/ruby-windows and squashes the following commits:

60add6e <Kouhei Sutou>  Run tests on AppVeyor
d17cc34 <Kouhei Sutou>  Add support for building on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants