Skip to content

Conversation

@llama90
Copy link
Contributor

@llama90 llama90 commented Mar 8, 2024

Rationale for this change

This happens when -DARROW_BUILD_BENCHMARKS=ON and sometimes cannot be detected by CI.

What changes are included in this PR?

Add missing expiration_time and app_metadata arguments as default.

Are these changes tested?

yes (build and run unit test)

Are there any user-facing changes?

No

@llama90 llama90 requested a review from lidavidm as a code owner March 8, 2024 14:05
@github-actions
Copy link

github-actions bot commented Mar 8, 2024

⚠️ GitHub issue #40422 has been automatically assigned in GitHub to PR creator.

@lidavidm lidavidm merged commit 8325ad1 into apache:main Mar 9, 2024
@lidavidm lidavidm removed the awaiting review Awaiting review label Mar 9, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Mar 9, 2024
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 8325ad1.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants