Skip to content

ARROW-5041: [C++] add GTest_SOURCE=BUNDLED to verify-release-candidate.bat#4056

Closed
bkietz wants to merge 1 commit intoapache:masterfrom
bkietz:5041-use-bundled-gtest-and-gmock-in-verify-re
Closed

ARROW-5041: [C++] add GTest_SOURCE=BUNDLED to verify-release-candidate.bat#4056
bkietz wants to merge 1 commit intoapache:masterfrom
bkietz:5041-use-bundled-gtest-and-gmock-in-verify-re

Conversation

@bkietz
Copy link
Copy Markdown
Member

@bkietz bkietz commented Mar 27, 2019

bundled GTest is currently required on Windows due to link issues with conda's GTest: #3984

@bkietz
Copy link
Copy Markdown
Member Author

bkietz commented Mar 27, 2019

@wesm

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Thanks!

@kou kou closed this in b5f8426 Mar 27, 2019
@wesm
Copy link
Copy Markdown
Member

wesm commented Mar 27, 2019

@kou I will try to verify the RC3 on Windows before RC4 and also check the Python wheels because of Antoine's comment

@kou
Copy link
Copy Markdown
Member

kou commented Mar 27, 2019

OK!

@bkietz bkietz deleted the 5041-use-bundled-gtest-and-gmock-in-verify-re branch April 8, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants