GH-40792: [C#] Fix slicing a previously sliced array #40793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
commented
Mar 26, 2024
|
|
||
| public static IArrowArray Slice(IArrowArray array, int offset, int length) | ||
| { | ||
| if (offset > array.Length) |
Contributor
Author
There was a problem hiding this comment.
This check and the length = Math.Min(... adjustment below are also both accounted for in ArrayData.Slice, so I removed them too.
github-actions
bot
added
awaiting committer review
CurtHagenlocher
approved these changes
Mar 26, 2024
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 4b0f3fd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #40792, slicing a previously sliced array would return incorrect results.
What changes are included in this PR?
Removes the duplicated logic accounting for the current offset in
ArrowArrayFactory, which is already handled byArrayData.Slice.Are these changes tested?
Yes, I added a unit test.
Are there any user-facing changes?
Yes, this is a user-facing bug fix.