Skip to content

Conversation

@duhanmin
Copy link
Contributor

@duhanmin duhanmin commented Apr 2, 2024

Rationale for this change

DictionaryProvider doesn't have get method.

What changes are included in this PR?

It should be lookup not get.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Couldn't find get method
@github-actions
Copy link

github-actions bot commented Apr 2, 2024

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Collaborator

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR. LGTM!

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 2, 2024

@github-actions crossbow submit preview-docs

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 2, 2024
@vibhatha
Copy link
Collaborator

vibhatha commented Apr 2, 2024

@kou @lidavidm shall we make the title name as Minor: Docs Update vector.rst to use lookup instead of get or something meaningful?

@vibhatha
Copy link
Collaborator

vibhatha commented Apr 2, 2024

@kou @lidavidm shall we make the title name as Minor: Docs Update vector.rst to use lookup instead of get or something meaningful?

@duhanmin appreciate if you could make this change 🙂

@github-actions
Copy link

github-actions bot commented Apr 2, 2024

Revision: 5151b23

Submitted crossbow builds: ursacomputing/crossbow @ actions-effb5b3ff9

Task Status
preview-docs GitHub Actions

@lidavidm
Copy link
Member

lidavidm commented Apr 2, 2024

er, yes, the PR title needs to change as a basic requirement - that goes without saying

@kou kou changed the title Update vector.rst MINOR: [Docs][Java] Fix wrong method usage in example Apr 2, 2024
@kou
Copy link
Member

kou commented Apr 2, 2024

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've updated the title and description.

@kou kou merged commit 782c52f into apache:main Apr 2, 2024
@kou kou removed the awaiting committer review Awaiting committer review label Apr 2, 2024
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 2, 2024
@vibhatha
Copy link
Collaborator

vibhatha commented Apr 3, 2024

er, yes, the PR title needs to change as a basic requirement - that goes without saying

Agreed!

Unfortunately I don't have the edit title access.

Thanks @kou 👍

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 782c52f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

`DictionaryProvider` doesn't have `get` method.

### What changes are included in this PR?

It should be `lookup` not `get`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

Authored-by: 野鹿 <359391169@qq.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants