Skip to content

ARROW-5160: [C++] Don't evaluate expression twice in ABORT_NOT_OK#4139

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

ARROW-5160: [C++] Don't evaluate expression twice in ABORT_NOT_OK#4139
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 10, 2019

This manifested itself as an abort in gRPC/Flight, as this macro was causing WritesDone to be called twice on a ClientWriter.

@codecov-io
Copy link

Codecov Report

Merging #4139 into master will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4139      +/-   ##
==========================================
+ Coverage   87.85%   88.58%   +0.72%     
==========================================
  Files         745      610     -135     
  Lines       91468    81804    -9664     
  Branches     1252        0    -1252     
==========================================
- Hits        80361    72467    -7894     
+ Misses      10988     9337    -1651     
+ Partials      119        0     -119
Impacted Files Coverage Δ
cpp/src/arrow/testing/gtest_util.h 100% <ø> (ø) ⬆️
cpp/src/arrow/csv/column-builder.cc 95.32% <0%> (-1.76%) ⬇️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff1bca...b063742. Read the comment docs.

Copy link
Member

@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants