ARROW-5160: [C++] Don't evaluate expression twice in ABORT_NOT_OK#4139
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4139 +/- ##
==========================================
+ Coverage 87.85% 88.58% +0.72%
==========================================
Files 745 610 -135
Lines 91468 81804 -9664
Branches 1252 0 -1252
==========================================
- Hits 80361 72467 -7894
+ Misses 10988 9337 -1651
+ Partials 119 0 -119Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This manifested itself as an abort in gRPC/Flight, as this macro was causing
WritesDoneto be called twice on aClientWriter.