ARROW-5164: [Gandiva][C++] Introduce murmur32 for 32 bit types. #4153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
praveenbingo
commented
Apr 15, 2019
praveenbingo
commented
- Use 32 bit hash functions for 32 bit types instead of truncating the 64 bit hash.
- Use 32 bit hash functions for 32 bit types instead of truncating the 64 bit hash.
pravindra
approved these changes
Apr 15, 2019
praveenbingo
added a commit
to dremio/arrow
that referenced
this pull request
Apr 15, 2019
- Use 32 bit hash functions for 32 bit types instead of truncating the 64 bit hash. Author: Praveen <praveen@dremio.com> Closes apache#4153 from praveenbingo/ARROW-5164 and squashes the following commits: eb15a33 <Praveen> Fix gcc issues. 8c369b4 <Praveen> Fix lint issues. 73b41a0 <Praveen> ARROW-5164: Introduce murmur32 for 32 bit types.
praveenbingo
added a commit
to dremio/arrow
that referenced
this pull request
Apr 15, 2019
- Use 32 bit hash functions for 32 bit types instead of truncating the 64 bit hash. Author: Praveen <praveen@dremio.com> Closes apache#4153 from praveenbingo/ARROW-5164 and squashes the following commits: eb15a33 <Praveen> Fix gcc issues. 8c369b4 <Praveen> Fix lint issues. 73b41a0 <Praveen> ARROW-5164: Introduce murmur32 for 32 bit types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.