ARROW-5186 [Plasma] Fix crash caused by improper free on CUDA memory#4177
Closed
shengjun1985 wants to merge 2 commits intoapache:masterfrom
shengjun1985:master
Closed
ARROW-5186 [Plasma] Fix crash caused by improper free on CUDA memory#4177shengjun1985 wants to merge 2 commits intoapache:masterfrom shengjun1985:master
shengjun1985 wants to merge 2 commits intoapache:masterfrom
shengjun1985:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4177 +/- ##
==========================================
+ Coverage 87.77% 89.18% +1.41%
==========================================
Files 758 617 -141
Lines 92346 82204 -10142
Branches 1251 0 -1251
==========================================
- Hits 81060 73317 -7743
+ Misses 11169 8887 -2282
+ Partials 117 0 -117
Continue to review full report at Codecov.
|
wesm
reviewed
Apr 24, 2019
cpp/src/plasma/test/client_tests.cc
Outdated
| AssertCudaRead(object_buffers[0].metadata, {42}); | ||
| } | ||
|
|
||
| TEST_F(TestPlasmaStore, DeleteObjectsGUPTest) { |
cpp/src/plasma/store.cc
Outdated
| #ifdef PLASMA_CUDA | ||
| std::shared_ptr<CudaContext> context_; | ||
| manager_->GetContext(object->device_num - 1, &context_); | ||
| context_->Free(object->pointer, object->data_size + object->metadata_size); |
Member
There was a problem hiding this comment.
Unchecked Status here (this would fail CI if we had GPU-enabled builds). Seems that EraseFromObjectTable will need to return Status now?
wesm
changed the title
Member
|
I'll wait for @pcmoritz to review |
Member
|
@pcmoritz can you review? |
Contributor
|
Yes, I'm looking at it now! |
pcmoritz
approved these changes
Apr 29, 2019
Contributor
pcmoritz
left a comment
pcmoritz
left a comment
There was a problem hiding this comment.
The code looks good to me!
I'll also test it on a CUDA enabled machine, feel free to merge if that has already been done.
Contributor
|
Tests are passing! Thanks for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.