ARROW-683: [C++/Python] Refactor to make Date32 and Date64 types for new metadata. Test IPC roundtrip #418
Conversation
…oundtrips, maintain existing Python behavior Change-Id: I437fb6fdfef5d9d0bcd42b97a33e428706b7f11f
… older autoconf Change-Id: I06915a8247e70b72a4ba48e46cac1b6709388bb1
|
@kou if you could look at the changes under c_glib and make sure this makes sense (per the ax_cxx_compile_stdcxx_11 issue) |
|
You don't need to add I think that your autoconf-archive is old. You can just add the following change for - case arrow::Type::type::DATE:
+ case arrow::Type::type::DATE32:It will pass tests on Travis CI. I'll add |
|
OK, I'll remove them, I just wanted to check that I could compile arrow-glib locally |
Change-Id: Ica64db5836606aa27999d017f834c269c88498bc
|
How do I update my autoconf-archive? From searching on the internet, this particular issue seems to occur quite frequently |
|
|
Change-Id: Ibca96335d82534c63e425ac2cd148aa130c8528d
|
@xhochy this is ready to be merged -- I created PARQUET-919 for fixing parquet_arrow separately |
Thanks! |
xhochy
left a comment
xhochy
left a comment
There was a problem hiding this comment.
LGTM but there are two // TODO statements which may need addressing
| Status Visit(const BinaryType& type) override { return WriteVarBytes("binary", type); } | ||
|
|
||
| Status Visit(const DateType& type) override { return WritePrimitive("date", type); } | ||
| // TODO |
There was a problem hiding this comment.
Is there still something to do here?
There was a problem hiding this comment.
Testing / metadata read/write for the JSON format -- ARROW-620
Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#418 from wesm/PARQUET-1164 and squashes the following commits: ca18e60 [Wes McKinney] Bump Arrow version to include ARROW-1808 d580b4f [Wes McKinney] Refactor to account for ARROW-1808 Change-Id: I526e111b5c4b170b13c5a25aa9c9ff3685e2f5aa
3 participants
Maintains existing Python behavior (datetime.date getting converted to milliseconds)