GH-40932: [Java] Implement TransferPair functionality for StringView #41861
Conversation
There was a problem hiding this comment.
How does this work when we're not rewriting the view buffers up above?
There was a problem hiding this comment.
There's not an existing helper for this? I don't think every vector should have its own copy of this code...
There was a problem hiding this comment.
No there is no helper for this. I looked into what is LargeListVector and BaseVariableWidthVector the code is mostly the same for validity buffer related split and transfer.
There was a problem hiding this comment.
Shall we file a separate issue to write a util for this?
There was a problem hiding this comment.
That's rather unfortunate. It should go into something like BitVectorHelper
There was a problem hiding this comment.
I agree. Shall I file an issue and work on it as a follow up?
There was a problem hiding this comment.
java/vector/src/test/java/org/apache/arrow/vector/TestSplitAndTransfer.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting changes
vibhatha
force-pushed
the
stringview-transferpair
branch
from
2440d6a to
4dddac9
Compare
github-actions
bot
added
awaiting change review
|
@lidavidm I updated the PR. |
github-actions
bot
added
awaiting changes
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthViewVector.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting review
github-actions
bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 706b3e0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…gView (apache#41861) ### Rationale for this change StringView implementation requires transferPair functionality which is required for C Data interface implementation as well. ### What changes are included in this PR? Adding transferPair functionality and corresponding test cases. ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#40932 Authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
2 participants
Rationale for this change
StringView implementation requires transferPair functionality which is required for C Data interface implementation as well.
What changes are included in this PR?
Adding transferPair functionality and corresponding test cases.
Are these changes tested?
Yes
Are there any user-facing changes?
No