ARROW-5270: [C++] reduce json-reader-test's working size#4264
Closed
bkietz wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5270: [C++] reduce json-reader-test's working size#4264bkietz wants to merge 1 commit intoapache:masterfrom
bkietz wants to merge 1 commit intoapache:masterfrom
Conversation
pitrou
reviewed
May 6, 2019
|
|
||
| TEST(ReaderTest, MultipleChunksParallel) { | ||
| int64_t count = 1 << 20; | ||
| int64_t count = 1 << 10; |
Member
There was a problem hiding this comment.
One possible pattern is to choose a different test size if Valgrind is enabled. We do this in other places:
#ifdef ARROW_VALGRIND
int64_t count = ...; // some moderate number
#else
int64_t count = ...; // some bigger number
#endifUltimately, it's your choice :-)
Member
Author
There was a problem hiding this comment.
The test was originally just 1kB. I changed the size around while looking for the benchmark discrepancy, and ended up checking in 1MB. It really doesn't need to be that large, I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valgrind on Travis is slow due to this test, which doesn't need to be so big. @pitrou