GH-43131: [CI] Attach lint failures to PR diff view#43133
Closed
kou wants to merge 1 commit intoapache:mainfrom
Closed
GH-43131: [CI] Attach lint failures to PR diff view#43133kou wants to merge 1 commit intoapache:mainfrom
kou wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
kou
force-pushed
the
ci-lint-failures
branch
5 times, most recently
from
884f071 to
4e64d49
Compare
kou
commented
Jul 3, 2024
| SET CMP0135 NEW) | ||
| endif() | ||
|
|
||
| set(ARROW_VERSION "17.0.0-SNAPSHOT") |
github-actions
bot
added
awaiting changes
|
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer. |
github-actions
bot
added
the
Status: stale-warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If we can attach lint failures to PR diff view, PR authors will fix lint failures without comments from reviewers.
What changes are included in this PR?
Detect diffs from
pre-commit run --show-diff-on-failureand convert them to "error" workflow commands.See also: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message
Are these changes tested?
Yes.
Are there any user-facing changes?
No.