GH-43514: [Python] Deprecate passing build flags to setup.py #43515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Python
awaiting committer review
raulcd
reviewed
Aug 1, 2024
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
I've tested locally, just a minor question but lgtm
github-actions
bot
added
awaiting changes
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
github-actions
bot
added
awaiting change review
raulcd
approved these changes
Aug 1, 2024
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 3193b95. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As mentioned in #41494 (comment) (while refactoring how to specify to the pyarrow build which components to build, i.e. to let it follow the Arrow C++ components by default), we do have a "feature" that you can specify which components to build directly to setup.py, like
python setup.py build_ext --with-parquet.This is currently not used in our own codebase, and is also not documented anymore, but we did document it in the past.
In general calling setup.py directly is not recommended (although for development installs, it is still useful), furthermore there are alternatives to those flags (relying on Arrow C++ or setting an environment variable), and this would go away anyhow in case we would move away from setuptools at some point.
So I think it is better to deprecate those options.
What changes are included in this PR?
Whenever a user passes such a
--with-flag, a warning is raised.Are these changes tested?
Tested it locally
Are there any user-facing changes?
Only for developers building pyarrow from source, they have to potentially update their build instructions.
setup.py --with-parquet) #43514