ARROW-4504: [C++] Reduce number of C++ unit test executables from 128 to 82#4442
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-4504: [C++] Reduce number of C++ unit test executables from 128 to 82#4442wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
I wasn't able to test Ninja build times on Windows because of bug https://issues.apache.org/jira/browse/ARROW-5473 |
Member
Author
|
@pravindra I rolled up a number of fast-running Gandiva tests. Have a look |
pitrou
approved these changes
Jun 3, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Looks fine to me. No regression here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This yields approximately 15% net improvement in build time when building with msbuild and
/MPon a quad-core desktop. Parallel test execution times on Linux/macOS should be unaffected -- I took care to only combine executables where it made sense and where execution time was already very fast (100s of milliseconds or less)