GH-44626: [Java] fix SplitAndTransfer throws for empty MapVector #44627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibhatha
reviewed
Nov 3, 2024
Collaborator
There was a problem hiding this comment.
can we just return if length=0
Contributor
Author
There was a problem hiding this comment.
Can do though my personal preference would be to avoid multiple returns. Current implementation is in keeping with how splitAndTransfer is implemented for other complex types (e.g. ListVector).
github-actions
bot
added
awaiting committer review
vibhatha
reviewed
Nov 3, 2024
Collaborator
There was a problem hiding this comment.
nit: use try-with-resources
Contributor
Author
There was a problem hiding this comment.
Note that there're several closeable resources here and toListVector cannot be constructed inside the same try as fromListVector. This is just to say that there'd be some ugly nesting if using try.
Collaborator
|
@lidavidm need some help to run the CIs. |
Signed-off-by: Maksim Yegorov <findmaksim@gmail.com>
lidavidm
reviewed
Nov 8, 2024
| MapVector dataVector = (MapVector) fromListVector.getDataVector(); | ||
| dataVector.allocateNew(); | ||
| // unset capacity to mimic observed failure mode | ||
| dataVector.getOffsetBuffer().capacity(0); |
Member
There was a problem hiding this comment.
Hmm, a list vector is supposed to have 1 offset when it's empty. But I suppose other parts of the library have this issue/"optimization"
github-actions
bot
added
awaiting changes
lidavidm
approved these changes
Nov 8, 2024
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5fe87a3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
lriggs
pushed a commit
to lriggs/arrow
that referenced
this pull request
Jul 15, 2025
apache#44627) Empty MapVector.splitAndTransfer throws `java.lang.IndexOutOfBoundsException`. Details in apache#44626 Fixed for MapVector as for other vector types in apache#41066 Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0. * GitHub Issue: apache#44626 Authored-by: Maksim Yegorov <59841139+maksimyego-db@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com>
lriggs
added a commit
to dremio/arrow
that referenced
this pull request
Jul 15, 2025
apache#44627) (#93) Empty MapVector.splitAndTransfer throws `java.lang.IndexOutOfBoundsException`. Details in apache#44626 Fixed for MapVector as for other vector types in apache#41066 Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0. * GitHub Issue: apache#44626 Authored-by: Maksim Yegorov <59841139+maksimyego-db@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com> Co-authored-by: Maksim Yegorov <997437+myegorov@users.noreply.github.com>
lriggs
added a commit
to dremio/arrow
that referenced
this pull request
Jul 15, 2025
…tor (apache#44631) (#94) * apacheGH-44626: [Java] fix SplitAndTransfer throws for empty MapVector (apache#44627) Empty MapVector.splitAndTransfer throws `java.lang.IndexOutOfBoundsException`. Details in apache#44626 Fixed for MapVector as for other vector types in apache#41066 Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0. * GitHub Issue: apache#44626 Authored-by: Maksim Yegorov <59841139+maksimyego-db@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com> * apacheGH-44344: [Java] fix VectorSchemaRoot.getTransferPair for NullVector (apache#44631) Do not throw [UnsupportedOperationException("Tried to get allocator from NullVector")](https://github.com/apache/arrow/blob/release-18.0.0-rc0/java/vector/src/main/java/org/apache/arrow/vector/NullVector.java#L160) from [VectorSchemaRoot.slice()](https://github.com/apache/arrow/blob/release-18.0.0-rc0/java/vector/src/main/java/org/apache/arrow/vector/VectorSchemaRoot.java#L341) when slicing a VSR containing a NullVector or ZeroVector. Details in apache#44344 Added unit test that would trigger an UnsupportedOperationException on the legacy path. * GitHub Issue: apache#44344 Authored-by: Maksim Yegorov <59841139+maksimyego-db@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com> --------- Signed-off-by: David Li <li.davidm96@gmail.com> Co-authored-by: Maksim Yegorov <997437+myegorov@users.noreply.github.com>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
apache#44627) ### Rationale for this change Empty MapVector.splitAndTransfer throws `java.lang.IndexOutOfBoundsException`. Details in apache#44626 ### What changes are included in this PR? Fixed for MapVector as for other vector types in apache#41066 ### Are these changes tested? Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0. * GitHub Issue: apache#44626 Authored-by: Maksim Yegorov <59841139+maksimyego-db@users.noreply.github.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Empty MapVector.splitAndTransfer throws
java.lang.IndexOutOfBoundsException. Details in #44626What changes are included in this PR?
Fixed for MapVector as for other vector types in #41066
Are these changes tested?
Added unit test mimicking the scenario we've observed where MapVector's offset buffer capacity is 0.