ARROW-5504 [R]: move use_threads argument to global option#4515
Closed
romainfrancois wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-5504 [R]: move use_threads argument to global option#4515romainfrancois wants to merge 2 commits intoapache:masterfrom
romainfrancois wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4515 +/- ##
===========================================
- Coverage 88.11% 74.67% -13.44%
===========================================
Files 850 54 -796
Lines 105774 3112 -102662
Branches 1253 0 -1253
===========================================
- Hits 93203 2324 -90879
+ Misses 12326 788 -11538
+ Partials 245 0 -245
Continue to review full report at Codecov.
|
r/tests/testthat/test-parquet.R
Outdated
Member
There was a problem hiding this comment.
Let's keep this test so that we're exercising the single-threaded code and ensuring equality. Just have to change the use_threads=FALSE to flip the option instead.
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
One note about testing but otherwise LGTM
romainfrancois
force-pushed
the
ARROW-5504/use_threads
branch
2 times, most recently
from
cfa7488 to
ae8dae2
Compare
romainfrancois
force-pushed
the
ARROW-5504/use_threads
branch
from
ae8dae2 to
445364a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At this point the function is not exported or documented and threads are always used, users would need to set
options(arrow.use_threads)to turn them off.