Skip to content

Conversation

@hiroyuki-sato
Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato commented Jan 24, 2025

Rationale for this change

Array::ValidateFull available in the C++ API.
But, GLib doesn't support that method yet.

What changes are included in this PR?

This PR adds a validation method in the array class.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@hiroyuki-sato hiroyuki-sato requested a review from kou as a code owner January 24, 2025 00:46
@github-actions
Copy link

⚠️ GitHub issue #44758 has been automatically assigned in GitHub to PR creator.

Comment on lines 221 to 224
value_offsets,
data,
Arrow::Buffer.new([0b01].pack("C*")),
-1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix indent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Expected style?

      array = Arrow::StringArray.new(1,
                                     value_offsets,
                                     Arrow::Buffer.new(data),
                                     Arrow::Buffer.new([0b01].pack("C*")),
                                     -1)

I used this style.

Arrow::StringArray.new(3,
value_offsets,
data,
Arrow::Buffer.new([0b011].pack("C*")),
-1))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jan 24, 2025
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jan 24, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit c6b6bfb into apache:main Jan 24, 2025
14 checks passed
@kou kou removed the awaiting change review Awaiting change review label Jan 24, 2025
@github-actions github-actions bot added the awaiting changes Awaiting changes label Jan 24, 2025
@kou
Copy link
Member

kou commented Jan 24, 2025

Thanks.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jan 24, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c6b6bfb.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

@hiroyuki-sato hiroyuki-sato deleted the topic/array-valite-full branch May 13, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants