-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-44758: [GLib] Add garrow_array_validate_full() #45342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
c_glib/test/test-array.rb
Outdated
| value_offsets, | ||
| data, | ||
| Arrow::Buffer.new([0b01].pack("C*")), | ||
| -1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix indent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Expected style?
array = Arrow::StringArray.new(1,
value_offsets,
Arrow::Buffer.new(data),
Arrow::Buffer.new([0b01].pack("C*")),
-1)I used this style.
arrow/c_glib/test/test-string-array.rb
Lines 25 to 29 in f4a63d4
| Arrow::StringArray.new(3, | |
| value_offsets, | |
| data, | |
| Arrow::Buffer.new([0b011].pack("C*")), | |
| -1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Thanks. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c6b6bfb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Array::ValidateFull available in the C++ API.
But, GLib doesn't support that method yet.
What changes are included in this PR?
This PR adds a validation method in the array class.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
garrow_array_validate_full()#44758