Skip to content

Conversation

@hiroyuki-sato
Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato commented Jan 30, 2025

Rationale for this change

#45390 implemented garrow_array_validate_full(). But it used validate_full not validate-full for error tag. We should use hyphen-separated words for error tag for consistency.

What changes are included in this PR?

validate_ful -> validate-full

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@hiroyuki-sato hiroyuki-sato requested a review from kou as a code owner January 30, 2025 09:12
@github-actions github-actions bot added the awaiting review Awaiting review label Jan 30, 2025
@github-actions
Copy link

⚠️ GitHub issue #45390 has been automatically assigned in GitHub to PR creator.

@kou kou changed the title GH-45390: [GLib] Fix typo. validate_full -> validate-full GH-45390: [GLib] Use hyphen-separated words for error tag Jan 30, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 73b8812 into apache:main Jan 30, 2025
12 checks passed
@kou kou removed the awaiting review Awaiting review label Jan 30, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 30, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 73b8812.

There were 8 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

@hiroyuki-sato hiroyuki-sato deleted the topic/fix-glib-typo branch May 13, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants