Skip to content

ARROW-5619: [C++] Make get_apache_mirror.py workable with Python 3.5#4583

Closed
kou wants to merge 1 commit intoapache:masterfrom
kou:cpp-apache-mirror-python-3.5
Closed

ARROW-5619: [C++] Make get_apache_mirror.py workable with Python 3.5#4583
kou wants to merge 1 commit intoapache:masterfrom
kou:cpp-apache-mirror-python-3.5

Conversation

@kou
Copy link
Member

@kou kou commented Jun 15, 2019

% python3 --version
Python 3.5.3
% python3 cpp/build-support/get_apache_mirror.py
Traceback (most recent call last):
  File "cpp/build-support/get_apache_mirror.py", line 31, in <module>
    print(json.loads(suggested_mirror)['preferred'])
  File "/usr/lib/python3.5/json/__init__.py", line 312, in loads
    s.__class__.__name__))
TypeError: the JSON object must be str, not 'bytes'

Debian stretch ships Python 3.5 as python3.

@codecov-io
Copy link

Codecov Report

Merging #4583 into master will increase coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4583      +/-   ##
=========================================
+ Coverage   88.57%     89%   +0.43%     
=========================================
  Files         860     707     -153     
  Lines      108022   95238   -12784     
  Branches     1253       0    -1253     
=========================================
- Hits        95678   84767   -10911     
+ Misses      12065   10471    -1594     
+ Partials      279       0     -279
Impacted Files Coverage Δ
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a255f0e...3d34858. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in e8c4230 Jun 16, 2019
@kou kou deleted the cpp-apache-mirror-python-3.5 branch June 16, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments